fix(security): serialize Mojo shared-memory payloads as JSON, not pickle - #1596
Draft
groupthinking wants to merge 1 commit into
Draft
fix(security): serialize Mojo shared-memory payloads as JSON, not pickle#1596groupthinking wants to merge 1 commit into
groupthinking wants to merge 1 commit into
Conversation
Removes the last pickle serialization in production code. Pickle bytes in a cross-process shared-memory segment force the receiver into pickle.loads, the same RCE pattern REM-001 removed from the Redis cache. Generated with [Linear](https://linear.app/myxstack/issue/GRV-423/addressing-issues#agent-session-1060aec4) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Contributor
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
pickle.dumps(message)with JSON inMojoTransportLayer._shared_memory_sendand drops thepickleimport — the last pickle serialization in production code. Pickle bytes in a cross-process shared-memory segment force any receiver intopickle.loads, the same RCE pattern REM-001 already removed from the Redis cache. Both message layers exposeto_dict(), so the payload is now a JSON object of the A2A message, MCP context, and transport hints.Context: the issue's attached plan is largely stale — SEC-001 (cache pickle), SEC-002 (npm vulns), and SEC-003 (
dangerouslySetInnerHTMLin the removedfrontend/) are already resolved perdocs/analysis/REMEDIATION_PLAN.md(re-verified 2026-08-04), andsrc/vera/no longer exists. This residual pickle usage was the remaining code-actionable finding.Note: the session ended before tests could be run against this change; please verify
tests/unit/test_security_fixes.pyin CI.